| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Mitsumasa KONDO <kondo(dot)mitsumasa(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tomáš Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: skipping pg_log in basebackup (was Re: pg_basebackup and pg_stat_tmp directory) |
| Date: | 2015-06-11 05:46:46 |
| Message-ID: | CAB7nPqRFr234mV0O0+FMMkY7YBoGXmSCWpQLSW-PgriAjTc+-w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 11, 2015 at 2:39 PM, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com> wrote:
> At 2015-06-11 14:28:36 +0900, michael(dot)paquier(at)gmail(dot)com wrote:
>>
>> After spending the night thinking about that, honestly, I think that
>> we should go with (2) and keep the base backup as light-weight as
>> possible and not bother about a GUC.
>
> OK. Then the patch I posted earlier should be sufficient.
Btw, one thing that 010_pg_basebackup.pl does not check is actually if
the files filtered by basebackup.c are included or not in the base
backup. We may want to add some extra checks regarding that...
Especially with your patch that filters things depending on if
log_directory is an absolute path or not.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2015-06-11 06:35:01 | Re: Draft release notes for 9.4.4 et al |
| Previous Message | Abhijit Menon-Sen | 2015-06-11 05:39:07 | Re: skipping pg_log in basebackup (was Re: pg_basebackup and pg_stat_tmp directory) |