| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Simplifying the interface of UpdateMinRecoveryPoint |
| Date: | 2016-07-13 21:04:49 |
| Message-ID: | CAB7nPqQg=KYYWzE9XGN3dnRscoUfX5_LLzqBsm3yia2+Lh+fog@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 13, 2016 at 10:31 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On 12 July 2016 at 23:49, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
>> Hence why not simplifying its interface and remove the force flag?
>
> Is this change needed as part of a feature? If not, I see no reason for
> change.
>
> If we all work towards meaningful features the code can be cleaned up as we
> go.
That's just refactoring. The interactions between the two arguments of
this routine is plain.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-07-13 21:05:25 | Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |
| Previous Message | Tom Lane | 2016-07-13 21:04:25 | Re: rethinking dense_alloc (HashJoin) as a memory context |