| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Kevin Grittner <kgrittn(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ants Aasma <ants(dot)aasma(at)eesti(dot)ee>, Kevin Grittner <kgrittn(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |
| Date: | 2016-07-13 21:05:25 |
| Message-ID: | 20160713210525.6l4ufjlnfmg5f6ni@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2016-07-13 15:57:02 -0500, Kevin Grittner wrote:
> A short answer is that a normal table's heap doesn't go through
> systable_getnext_ordered(). That function is used both for cases
> where the check should not be made, like toast_delete_datum(), and
> cases where it should, like toast_fetch_datum().
It *has* to be be made for toast_delete_datum(). Otherwise we could end
up deleting a since reused toast id. Or am I missing something?
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2016-07-14 13:40:35 | pgsql: Remove reference to range mode in pg_xlogdump error |
| Previous Message | Kevin Grittner | 2016-07-13 20:57:02 | Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-07-13 21:14:06 | Document that vacuum can't truncate if old_snapshot_threshold >= 0 |
| Previous Message | Michael Paquier | 2016-07-13 21:04:49 | Re: Simplifying the interface of UpdateMinRecoveryPoint |