| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Fix multiple bugs and infelicities in pg_rewind. |
| Date: | 2015-04-12 08:46:23 |
| Message-ID: | CAB7nPqQYr8jsxOuBeU-8vYY_HxHHoJwcqCTyH3txya1=G+TDUQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Mon, Mar 30, 2015 at 9:02 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Fix multiple bugs and infelicities in pg_rewind.
>
> Bugs all spotted by Coverity, including wrong realloc() size request
> and memory leaks. Cosmetic improvements by me.
>
> The usage of the global variable "filemap" here is still pretty awful,
> but at least I got rid of the gratuitous aliasing in several routines
> (which was helping to annoy Coverity, as well as being a bug risk).
Coverity points out that a call to PQclear() in receiveFileChunks of
libpq_fetch.c is missing as the result still leaks resources when
status is PGRES_TUPLES_OK. Please see the patch attached.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20150412_pgrewind_leak.patch | text/x-patch | 358 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2015-04-12 17:12:55 | pgsql: Add system view pg_stat_ssl |
| Previous Message | Heikki Linnakangas | 2015-04-12 07:51:17 | pgsql: Remove duplicated words in comments. |