Re: pgsql: Fix multiple bugs and infelicities in pg_rewind.

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix multiple bugs and infelicities in pg_rewind.
Date: 2015-04-12 19:48:02
Message-ID: 552ACBF2.6090502@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 04/12/2015 11:46 AM, Michael Paquier wrote:
> On Mon, Mar 30, 2015 at 9:02 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Fix multiple bugs and infelicities in pg_rewind.
>>
>> Bugs all spotted by Coverity, including wrong realloc() size request
>> and memory leaks. Cosmetic improvements by me.
>>
>> The usage of the global variable "filemap" here is still pretty awful,
>> but at least I got rid of the gratuitous aliasing in several routines
>> (which was helping to annoy Coverity, as well as being a bug risk).
>
> Coverity points out that a call to PQclear() in receiveFileChunks of
> libpq_fetch.c is missing as the result still leaks resources when
> status is PGRES_TUPLES_OK. Please see the patch attached.

Applied, thanks.

- Heikki

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2015-04-13 03:54:45 pgsql: emacs: Set indent-tabs-mode in perl-mode
Previous Message Heikki Linnakangas 2015-04-12 19:47:49 pgsql: Free leaked result set in pg_rewind