Re: Commenting a FK crashes ALTER TABLE statements

On Mon, May 15, 2017 at 11:37 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> On Mon, May 15, 2017 at 1:05 PM, David Rowley
>> <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
>>> It seems there's just some missing pstrdup() calls in
>>> RebuildConstraintComment().
>>>
>>> The attached should fix it.
>
>> I was just finishing to debug it :)
>> It is surprising that we have not caught this earlier as comment
>> re-creation handling in ALTER TABLE has been reworked some time ago
>> already. This means that we did not stress this code enough. Attached
>> is the previous fix, completed with a set of regression tests.
>
> Yeah, there should at least be a test case to cover the known crash.
>
> I'll take this one, unless some other committer is already on it.

Thanks. (committed as 12590c5d)
--
Michael