| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Marko Elezovic <marko(dot)elezovic(at)oradian(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Commenting a FK crashes ALTER TABLE statements |
| Date: | 2017-05-15 14:37:12 |
| Message-ID: | 10243.1494859032@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Mon, May 15, 2017 at 1:05 PM, David Rowley
> <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
>> It seems there's just some missing pstrdup() calls in
>> RebuildConstraintComment().
>>
>> The attached should fix it.
> I was just finishing to debug it :)
> It is surprising that we have not caught this earlier as comment
> re-creation handling in ALTER TABLE has been reworked some time ago
> already. This means that we did not stress this code enough. Attached
> is the previous fix, completed with a set of regression tests.
Yeah, there should at least be a test case to cover the known crash.
I'll take this one, unless some other committer is already on it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2017-05-15 14:51:50 | Re: BUG #14648: counts for queries using array unnesting is incorrect |
| Previous Message | Peter Eisentraut | 2017-05-15 14:34:02 | Re: Concurrent ALTER SEQUENCE RESTART Regression |