From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
Subject: | Re: pg_regress --help missing description of --bindir |
Date: | 2016-01-07 02:19:15 |
Message-ID: | CAB7nPqQV1AJWpQ5p1mQ6x+AUh9C5vxZVHLUzYRU4bob-0ROj2g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Thu, Jan 7, 2016 at 4:53 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Michael Paquier wrote:
>> Hi all,
>>
>> I just bumped into the issue defined in $subject.
>> Attached is a patch.
>
> I don't understand the parenthical remark. Do you mean that if you pass
> "--bindir" without an argument it uses PATH? That would be weird; but
> if that's how it works, then it should look like --bindir[=DIR].
From pg_regress.c:
/* "--bindir=" means to use PATH */
if (strlen(optarg))
bindir = strdup(optarg);
else
bindir = NULL;
break;
> If you
> don't mean that, then I think the proposed wording is confusing. Maybe
> "PATH is searched if this option not given"?
That's trickier. PGBINDIR is used if this option is not given :)
Do you prefer the attached?
--
Michael
Attachment | Content-Type | Size |
---|---|---|
pgregress_help_v2.patch | application/x-patch | 845 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2016-01-07 04:13:51 | Re: BUG #13594: pg_ctl.exe redirects stderr to Windows Events Log if stderr is redirected to pipe |
Previous Message | Paul | 2016-01-07 00:14:07 | Re: BUG #13846: INSERT ON CONFLICT consumessequencersonconflicts |