Re: pg_dump doesn't dump new objects created in schemas from extensions

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Martín Marqués <martin(at)2ndquadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: pg_dump doesn't dump new objects created in schemas from extensions
Date: 2016-06-17 06:35:25
Message-ID: CAB7nPqQJzP1dLCwa9uj-keJafmLd3KXDQbRmsSYZbkNz3nu_uA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, Jun 17, 2016 at 4:21 AM, Martín Marqués <martin(at)2ndquadrant(dot)com> wrote:
> IMO, this assignment:
>
> tbinfo->dobj.dump = tbinfo->dobj.namespace->dobj.dump_contains;
>
> should be replaced by a call to some new function which would be more
> or less a copy of selectDumpableNamespace, but without the
> checkExtensionMembership call.

Ah, I see. Yes this is definitely wrong. The namespace itself may be
part of an extension but we do not check for it at all. See for
example the patch attached that is giving what I would expect is the
correct behavior.
--
Michael

Attachment Content-Type Size
dump-tab-extension.patch invalid/octet-stream 1.1 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message John R Pierce 2016-06-17 08:04:26 Re: BUG #14197: ERROR: character with byte sequence 0x81 in encoding "WIN1252" has no equivalent in encoding "UTF8"
Previous Message Michael Paquier 2016-06-17 05:59:09 Re: BUG #13907: Restore materialized view throw permission denied