Re: pg_dump doesn't dump new objects created in schemas from extensions

From: Martín Marqués <martin(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: pg_dump doesn't dump new objects created in schemas from extensions
Date: 2016-06-17 17:21:01
Message-ID: 24a4d9cf-025d-d855-fe76-3af3f878174d@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

El 17/06/16 a las 03:35, Michael Paquier escribió:
> On Fri, Jun 17, 2016 at 4:21 AM, Martín Marqués <martin(at)2ndquadrant(dot)com> wrote:
>> IMO, this assignment:
>>
>> tbinfo->dobj.dump = tbinfo->dobj.namespace->dobj.dump_contains;
>>
>> should be replaced by a call to some new function which would be more
>> or less a copy of selectDumpableNamespace, but without the
>> checkExtensionMembership call.
>
> Ah, I see. Yes this is definitely wrong. The namespace itself may be
> part of an extension but we do not check for it at all. See for
> example the patch attached that is giving what I would expect is the
> correct behavior.

This is a new version of your patch that checks for schema inclusion or
exclusion.

If there are no complains, I could apply similar changes on other
objects for a more complete patch.

Thoughts, objections?

--
Martín Marqués http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
dump-table-on-extension-schema.patch invalid/octet-stream 1.9 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Albin, Lloyd P 2016-06-17 17:34:41 Re: BUG #14197: ERROR: character with byte sequence 0x81 in encoding "WIN1252" has no equivalent in encoding "UTF8"
Previous Message Jehan-Guillaume de Rorthais 2016-06-17 14:28:50 Re: Segmentation fault with postgres -C external_pid_file