Re: WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Mark Dilger <mark(at)port25(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended
Date: 2014-12-11 03:57:35
Message-ID: CAB7nPqQ5XZd4AdbisXUyGGhsaOBM8Mk8BHK0uSB3XiPw5w-wiQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 11, 2014 at 7:44 AM, Mark Dilger <mark(at)port25(dot)com> wrote:

> At line 1787 of outfuncs.c, the line:
>
> WRITE_UINT_FIELD(reltablespace)
>
> should probably say
>
> WRITE_OID_FIELD(reltablespace)
>
> since that variable is of type Oid, not uint32.
> Granted, these two macros are interchangeable,
> but they won't be if we ever move to 64-bit Oids.
>
For correctness you are right. Looks like you spent quite some time looking
at that..
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2014-12-11 04:45:21 Re: On partitioning
Previous Message Andres Freund 2014-12-11 03:57:30 Re: logical column ordering