WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended

From: Mark Dilger <mark(at)port25(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended
Date: 2014-12-10 22:44:50
Message-ID: ABD1B077-93FA-4D55-B6A5-5B295E002C64@port25.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At line 1787 of outfuncs.c, the line:

WRITE_UINT_FIELD(reltablespace)

should probably say

WRITE_OID_FIELD(reltablespace)

since that variable is of type Oid, not uint32.
Granted, these two macros are interchangeable,
but they won't be if we ever move to 64-bit Oids.

mark

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-12-10 23:01:09 Re: Casting issues with domains
Previous Message Fabrízio de Royes Mello 2014-12-10 21:55:17 Fix typo um vacuumdb tests