Re: Undesirable whitespace treatment in mail archive display

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-www(at)lists(dot)postgresql(dot)org
Subject: Re: Undesirable whitespace treatment in mail archive display
Date: 2018-06-11 17:58:57
Message-ID: CAB448F8-AD71-42D5-B18C-A04C733CA092@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

> On 11 Jun 2018, at 19:52, Jonathan S. Katz <jkatz(at)postgresql(dot)org> wrote:
>
>>
>> On Jun 11, 2018, at 1:47 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>> Since we moved to the new website design, the mailing list archives
>> display all messages with leading indentation suppressed. This can
>> be pretty awful, eg in the code fragment here:
>>
>> https://www.postgresql.org/message-id/20180611170812.7ypf6xs6dlteo57j@alap3.anarazel.de
>>
>> Looking closer, I think it may not just be leading indentation that
>> gets lost; seems like *any* whitespace string gets smashed to a
>> single space, cf followup at
>>
>> https://www.postgresql.org/message-id/7382.1528737252%40sss.pgh.pa.us
>>
>> which certainly does not look like it did in my outbox.
>>
>> I assume this is just an ill-considered stylesheet choice somewhere
>> ... can we fix it please?
>
> Hmm…agreed. I’m going to check the old code to see how that was handled. This
> may have occurred when trying to make the archives readable across different
> viewports.

The below diff will retain the whitespace included the post. It doesn’t seem
to make it less readable on smaller viewports (although more scrolling), but I
only tested quickly so more input is welcome.

cheers ./daniel

diff --git a/media/css/main.css b/media/css/main.css
index 6221d90..46e427d 100644
--- a/media/css/main.css
+++ b/media/css/main.css
@@ -771,6 +771,7 @@ h3.messages {
font-size: 0.8em;
line-height: 1.2em;
margin: 0 auto;
+ white-space: pre;
}

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Jonathan S. Katz 2018-06-11 18:09:21 Re: Undesirable whitespace treatment in mail archive display
Previous Message Jonathan S. Katz 2018-06-11 17:52:32 Re: Undesirable whitespace treatment in mail archive display