| From: | Marcos Pegoraro <marcos(at)f10(dot)com(dot)br> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Erik Wienhold <ewie(at)ewie(dot)name>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump --no-comments confusion |
| Date: | 2024-11-18 21:36:45 |
| Message-ID: | CAB-JLwbzK63Vn=Dv9wSje0BsAdTXTgau5cwVZkG1ZvTBjJcabQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
But it would be good to have this patch applied to all supported versions,
as soon as nothing was changed on that pg_dump option, no ?
regards
Marcos
Em seg., 18 de nov. de 2024 às 18:30, Bruce Momjian <bruce(at)momjian(dot)us>
escreveu:
> On Tue, Nov 5, 2024 at 10:12:20AM +0100, Álvaro Herrera wrote:
> > On 2024-Nov-04, Erik Wienhold wrote:
> >
> > > I think Bruce's suggestion is pretty clear that it does not mean line
> or
> > > block comments, but rather the COMMENT command. But I also think that
> > > "SQL" in front of the command name is unnecessary [...]
> >
> > +1 for "Do not dump COMMENT commands", which is what I think you're
> > saying.
>
> Patch applied to master.
>
> --
> Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
> EDB https://enterprisedb.com
>
> When a patient asks the doctor, "Am I going to die?", he means
> "Am I going to die soon?"
>
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2024-11-18 21:38:53 | Re: Showing applied extended statistics in explain Part 2 |
| Previous Message | Bruce Momjian | 2024-11-18 21:30:48 | Re: pg_dump --no-comments confusion |