Re: TypeInfoCache.getPGType(pgTypeName) drops schema name when caching

From: Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>
To: Michael Glaesemann <grzm(at)seespotcode(dot)net>
Cc: List <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: TypeInfoCache.getPGType(pgTypeName) drops schema name when caching
Date: 2017-07-16 16:21:23
Message-ID: CAB=Je-GSx6U05GAVaiU4tQsP01CyWVAGJOZmo=tm+zykcAGcJQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

Michael>The caching to the cars.colors type name is different depending on
whether getPGType(pgTypeName) and getPGType(oid) is doing the caching.
getPGType(pgTypeName) doesn't include the schema name

This does sound odd on the first sight.
You might try to file a PR to see if the change would fail some existing
tests.

There was a recent change
https://github.com/pgjdbc/pgjdbc/commit/cddcd185cc71267e8eb177c6ba1dab3f029da089#diff-9cedabddb25727db7a1346738c8b7b5dR522
that
did touch _pgNameToOid.
We might want to use some common approach for _pgNameToOid.

Vladimir

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Michael Glaesemann 2017-07-16 17:04:27 Re: TypeInfoCache.getPGType(pgTypeName) drops schema name when caching
Previous Message Michael Glaesemann 2017-07-16 16:06:51 Re: TypeInfoCache.getPGType(pgTypeName) drops schema name when caching