| From: | Michael Glaesemann <grzm(at)seespotcode(dot)net> |
|---|---|
| To: | Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com> |
| Cc: | List <pgsql-jdbc(at)postgresql(dot)org> |
| Subject: | Re: TypeInfoCache.getPGType(pgTypeName) drops schema name when caching |
| Date: | 2017-07-16 17:04:27 |
| Message-ID: | 3B76CB0B-C216-44D9-A54E-DF6E518BAEC3@seespotcode.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-jdbc |
> On 2017-07-16, at 11:21, Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com> wrote:
>
> Michael>The caching to the cars.colors type name is different depending on whether getPGType(pgTypeName) and getPGType(oid) is doing the caching. getPGType(pgTypeName) doesn't include the schema name
>
> This does sound odd on the first sight.
> You might try to file a PR to see if the change would fail some existing tests.
Will do. Thanks!
>
> There was a recent change https://github.com/pgjdbc/pgjdbc/commit/cddcd185cc71267e8eb177c6ba1dab3f029da089#diff-9cedabddb25727db7a1346738c8b7b5dR522 that did touch _pgNameToOid.
> We might want to use some common approach for _pgNameToOid.
>
> Vladimir
Michael Glaesemann
grzm seespotcode net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | AlexElin | 2017-07-23 14:05:54 | [pgjdbc/pgjdbc] 5b65e2: test: migrate tests to JUnit 4 |
| Previous Message | Vladimir Sitnikov | 2017-07-16 16:21:23 | Re: TypeInfoCache.getPGType(pgTypeName) drops schema name when caching |