| From: | Joseph Koshakow <koshy44(at)gmail(dot)com> |
|---|---|
| To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Subject: | Re: Remove dependence on integer wrapping |
| Date: | 2024-06-14 02:56:38 |
| Message-ID: | CAAvxfHdhEz4eF7z1wNn_4C4Gkt+e-h7OjzKUJXt7CE+CvubqcQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 13, 2024 at 10:48 PM Joseph Koshakow <koshy44(at)gmail(dot)com> wrote:
> I've attached
> v4-0002-Handle-overflow-in-money-arithmetic.patch which adds some
> overflow checks and tests. I didn't address the float multiplication
> because I didn't see any helper methods in int.h. I did some some
> useful helpers in float.h, but they raise an error directly instead
> of returning a bool. Would those be appropriate for use with the
> money type? If not I can refactor out the inner parts into a new method
> that returns a bool.
> v4-0001-Remove-dependence-on-integer-wrapping.patch is unchanged, I
> just incremented the version number.
Oops I left a careless mistake in that last patch, my apologies. It's
fixed in the attached patches.
Thanks,
Joe Koshakow
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0002-Handle-overflow-in-money-arithmetic.patch | text/x-patch | 5.5 KB |
| v5-0001-Remove-dependence-on-integer-wrapping.patch | text/x-patch | 13.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tender Wang | 2024-06-14 03:02:43 | Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop() |
| Previous Message | Joseph Koshakow | 2024-06-14 02:48:14 | Re: Remove dependence on integer wrapping |