| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Christensen <david(dot)christensen(at)crunchydata(dot)com>, Shinya11(dot)Kato(at)nttdata(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] expand the units that pg_size_pretty supports on output |
| Date: | 2021-07-07 02:47:22 |
| Message-ID: | CAApHDvrYBkQX7Da=1VW7oOA5oek7yF-vk=ciuJvQRfJX88hLsw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 7 Jul 2021 at 02:54, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Minor nit: use "const char *text" in the struct declaration, so
> that all of the static data can be placed in fixed storage.
Thanks for pointing that out.
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > (I'm not sure why pgindent removed the space between != and NULL, but
> > it did, so I left it.)
>
> It did that because "text" is a typedef name, so it's a bit confused
> about whether the statement is really a declaration. Personally I'd
> have used "name" or something like that for that field, anyway.
I should have thought of that. Thanks for highlighting it. I've
renamed the field.
Updated patch attached.
David
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Use-lookup-table-for-units-in-pg_size_pretty-and-.patch | application/octet-stream | 7.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yura Sokolov | 2021-07-07 03:00:47 | Re: rand48 replacement |
| Previous Message | David Rowley | 2021-07-07 02:44:51 | Re: [PATCH] expand the units that pg_size_pretty supports on output |