Re: [PATCH] expand the units that pg_size_pretty supports on output

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: David Christensen <david(dot)christensen(at)crunchydata(dot)com>, Shinya11(dot)Kato(at)nttdata(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] expand the units that pg_size_pretty supports on output
Date: 2021-07-06 14:54:43
Message-ID: 1677540.1625583283@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> Does anyone want to have a look over this? If not, I plan to push it
> in the next day or so.

Minor nit: use "const char *text" in the struct declaration, so
that all of the static data can be placed in fixed storage.

> (I'm not sure why pgindent removed the space between != and NULL, but
> it did, so I left it.)

It did that because "text" is a typedef name, so it's a bit confused
about whether the statement is really a declaration. Personally I'd
have used "name" or something like that for that field, anyway.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-07-06 14:58:42 Re: Pipeline mode and PQpipelineSync()
Previous Message Jeevan Ladhe 2021-07-06 14:48:47 Re: .ready and .done files considered harmful