Re: wrong comments in ClassifyUtilityCommandAsReadOnly

On Sat, 21 Dec 2024 at 17:06, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> * Note the definitions of the relevant flags in src/include/utility/tcop.h.
> */
> static int
> ClassifyUtilityCommandAsReadOnly(Node *parsetree)
>
> Is the comment wrong?
>
> it should be
> " * Note the definitions of the relevant flags in src/include/tcop/utility.h."

Yeah. There is no tcop.h.

I used the attached (not exactly very pretty) script to find a few more.

git grep -h -E "\Wsrc/[\w_/]*" -- '*.[ch]' | tr -d '"' | tr -d \'\" |
xargs -n 1 ./fileexists.sh | grep "does not"

There are plenty of places that reference files not starting with
"src/". It might be good to verify there's some subdirectory in the
source tree that match those, however, I didn't think of a creative
way to identify those ones.

David