Re: wrong comments in ClassifyUtilityCommandAsReadOnly

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: wrong comments in ClassifyUtilityCommandAsReadOnly
Date: 2024-12-23 03:37:40
Message-ID: 1250308.1734925060@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> + * The "DefineAggregate" routine take the parse tree and pick out the
> + * appropriate arguments/flags, passing the results to
> + * "AggregateCreate" routine (src src/backend/catalog) that do the actual
> + * catalog-munging. These routines also verify permission of the user to
> + * execute the command.

The grammar needs some help here. Also, rather than simply remove
define.c's entire header comment, maybe we should write something
relevant about what it does? Good catches otherwise.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-12-23 03:42:25 Re: Fix a wrong comment in load_file()
Previous Message cca5507 2024-12-23 02:58:49 Fix a wrong comment in load_file()