From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Reduce the number of special cases to build contrib modules on windows |
Date: | 2021-04-20 03:00:53 |
Message-ID: | CAApHDvrPBpwToJFD3fFizVU38ZyD3xQdFkc0VT7jbPCY9=ZyOA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, 20 Apr 2021 at 09:28, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 4/19/21 12:24 PM, Alvaro Herrera wrote:
> >> diff --git a/src/tools/msvc/MSBuildProject.pm b/src/tools/msvc/MSBuildProject.pm
> >> index ebb169e201..68606a296d 100644
> >> --- a/src/tools/msvc/MSBuildProject.pm
> >> +++ b/src/tools/msvc/MSBuildProject.pm
> >> @@ -310,11 +310,12 @@ sub WriteItemDefinitionGroup
> >> my $targetmachine =
> >> $self->{platform} eq 'Win32' ? 'MachineX86' : 'MachineX64';
> >>
> >> - my $includes = $self->{includes};
> >> - unless ($includes eq '' or $includes =~ /;$/)
> >> + my $includes = "";
> >> + foreach my $inc (@{ $self->{includes} })
> >> {
> >> - $includes .= ';';
> >> + $includes .= $inc . ";";
> >> }
> > Perl note: you can do this more easily as
> >
> > my $includes = join ';', @{$self->{includes}};
> > $includes .= ';' unless $includes eq '';
> >
>
> or even more simply:
>
>
> my $includes = join ';', @{$self->{includes}}, "";
Both look more compact. Thanks. I'll include this for the next version.
David
From | Date | Subject | |
---|---|---|---|
Next Message | Julien Rouhaud | 2021-04-20 03:02:31 | Re: Bogus collation version recording in recordMultipleDependencies |
Previous Message | Peter Geoghegan | 2021-04-20 02:58:37 | Re: amcheck eating most of the runtime with wal_consistency_checking |