| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Reduce the number of special cases to build contrib modules on windows |
| Date: | 2021-04-19 21:28:02 |
| Message-ID: | 1da51443-6b47-d012-cfda-254c353c5148@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/19/21 12:24 PM, Alvaro Herrera wrote:
>> diff --git a/src/tools/msvc/MSBuildProject.pm b/src/tools/msvc/MSBuildProject.pm
>> index ebb169e201..68606a296d 100644
>> --- a/src/tools/msvc/MSBuildProject.pm
>> +++ b/src/tools/msvc/MSBuildProject.pm
>> @@ -310,11 +310,12 @@ sub WriteItemDefinitionGroup
>> my $targetmachine =
>> $self->{platform} eq 'Win32' ? 'MachineX86' : 'MachineX64';
>>
>> - my $includes = $self->{includes};
>> - unless ($includes eq '' or $includes =~ /;$/)
>> + my $includes = "";
>> + foreach my $inc (@{ $self->{includes} })
>> {
>> - $includes .= ';';
>> + $includes .= $inc . ";";
>> }
> Perl note: you can do this more easily as
>
> my $includes = join ';', @{$self->{includes}};
> $includes .= ';' unless $includes eq '';
>
or even more simply:
my $includes = join ';', @{$self->{includes}}, "";
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-04-19 21:37:50 | Re: "could not find pathkey item to sort" for TPC-DS queries 94-96 |
| Previous Message | Alan Hodgson | 2021-04-19 21:19:38 | Re: archive_commnad parameter question |