Re: Use LIMIT instead of Unique for DISTINCT when all distinct pathkeys are redundant

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use LIMIT instead of Unique for DISTINCT when all distinct pathkeys are redundant
Date: 2022-10-26 08:25:16
Message-ID: CAApHDvqyfo2i5jPQz7DjX=PwxP=_PHvo53aq=NPgO+B_8SKdCw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 14 Oct 2022 at 15:15, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> The v3 patch looks good to me.

Thank you for looking at that.

One other thought I had about the duplicate "Limit" node in the final
plan was that we could make the limit clause an Expr like
LEAST(<existing limit clause>, 1). That way we could ensure we get at
most 1 row, but perhaps less if the expression given in the LIMIT
clause evaluated to 0. This will still work correctly when the
existing limit evaluates to NULL. I'm still just not that keen on this
idea as it means still having to either edit the parse's limitCount or
store the limit details in a new field in PlannerInfo and use that
when making the final LimitPath. However, I'm still not sure doing
this is worth the extra complexity.

If nobody else has any thoughts on this or the patch in general, then
I plan to push it in the next few days.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message jacktby@gmail.com 2022-10-26 09:13:49 confused with name in the pic
Previous Message Bharath Rupireddy 2022-10-26 08:11:12 Re: Some regression tests for the pg_control_*() functions