| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use generation memory context for tuplestore.c |
| Date: | 2024-07-05 05:54:38 |
| Message-ID: | CAApHDvqg7oB+2e0nsQf9iSVYbrs=bZ0t8yvJ8M3F7d2cQFCRAQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 3 Jul 2024 at 22:41, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Wed, 3 Jul 2024 at 00:20, Matthias van de Meent
> > Lastly, I think this would benefit from a test in
> > regress/sql/explain.sql, as the test changes that were included
> > removed the only occurrance of a Materialize node from the regression
> > tests' EXPLAIN outputs.
>
> I've modified the tests where the previous patch disabled
> enable_material to enable it again and mask out the possibly unstable
> part. Do you think that's an ok level of testing?
I spent quite a bit more time today looking at these patches. Mostly
that amounted to polishing comments more.
I've pushed them both now.
Thank you both of you for reviewing these.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2024-07-05 06:27:44 | Re: Conflict Detection and Resolution |
| Previous Message | Amit Kapila | 2024-07-05 05:40:00 | Re: walsender.c comment with no context is hard to understand |