| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: walsender.c comment with no context is hard to understand |
| Date: | 2024-07-05 05:40:00 |
| Message-ID: | CAA4eK1JVrKjJvHiyVziDO8k9hwXEanHT8PVXzUVmNhrz9od32A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 28, 2024 at 6:30 PM Bertrand Drouvot
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>
> On Fri, Jun 28, 2024 at 03:15:22PM +0530, Amit Kapila wrote:
> > On Fri, Jun 28, 2024 at 12:55 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > >
> >
> > I don't know whether your assumption is correct. AFAICS, those two
> > lines should be together. Let us ee if Bertrand remembers anything?
> >
>
> IIRC the WalSndWaitForWal() call has been moved to ensure that we can determine
> the timeline accurately.
>
This part is understandable but I don't understand the part of the
comment (This is needed to determine am_cascading_walsender accurately
..) atop a call to WalSndWaitForWal(). The am_cascading_walsender is
determined based on the results of RecoveryInProgress(). Can the wait
for WAL by using WalSndWaitForWal() change the result of
RecoveryInProgress()?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2024-07-05 05:54:38 | Re: Use generation memory context for tuplestore.c |
| Previous Message | Hayato Kuroda (Fujitsu) | 2024-07-05 05:39:05 | RE: Slow catchup of 2PC (twophase) transactions on replica in LR |