Re: [PATCH] Documentation: Fix minor grammatical and formatting issues

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Noboru Saito <noborusai(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Documentation: Fix minor grammatical and formatting issues
Date: 2025-04-21 04:03:09
Message-ID: CAApHDvqbSJQC0k+-duXO-6CBg6k5C9Wda+fFEUvxmtD=gxrfNQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 21 Apr 2025 at 15:06, Noboru Saito <noborusai(at)gmail(dot)com> wrote:
> 1. Remove unnecessary blank lines (blankline.diff)

Looks good.

> 2. Fix repeated "to to" in several command reference files (toto.diff)

- Specifies the name of the database to connect to to discover which
+ Specifies the name of the database to connect to discover which

What's there is acceptable English, but it's maybe confusing to a
non-native speaker and might be worth adjusting so it's easier to
parse. "connect to to discover" is just short for "connect to in order
to discover". If it's confusing, maybe we could rephrase the whole
sentence. How about:

"When the <option>-a</option>/<option>--all</option> is used, connect
to this database to gather the list of databases to vacuum."

> 3. Fix period instead of comma in enumeration (comma.diff)

Looks good.

> 4. Standardize inline tags in libpq documentation (tagmiss.diff)

Looks good.

> 5. Remove redundant "that that" constructions (thatthat.diff)

I don't see anything wrong here. [1] does a better job of explaining
#5 than I can.

David

[1] https://english.stackexchange.com/questions/492349/is-my-use-of-that-that-in-this-sentence-gramaticaly-correct

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2025-04-21 04:13:47 Re: Allow database owners to CREATE EVENT TRIGGER
Previous Message Steve Chavez 2025-04-21 04:02:47 Re: Allow database owners to CREATE EVENT TRIGGER