From: | Noboru Saito <noborusai(at)gmail(dot)com> |
---|---|
To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Documentation: Fix minor grammatical and formatting issues |
Date: | 2025-04-21 20:53:25 |
Message-ID: | CAAM3qn+seOHwuYKmixud8NgVBsOkqzsX55GEvbq09m_S4vA4-Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thank you for the review! I appreciate your detailed feedback.
Regarding "to to" and "that that", I agree that they might be
technically acceptable.
However, I personally find them a bit harder to parse and they
increase the chance of misreading for me.
Your suggested alternative for "to to" is much clearer!
Ultimately, if leaving them as-is is perfectly fine, I'm happy to
defer to your judgment.
But I would certainly welcome the improvement if you decide to revise
those phrases.
Thanks again for your time and consideration.
2025年4月21日(月) 13:03 David Rowley <dgrowleyml(at)gmail(dot)com>:
>
> On Mon, 21 Apr 2025 at 15:06, Noboru Saito <noborusai(at)gmail(dot)com> wrote:
> > 1. Remove unnecessary blank lines (blankline.diff)
>
> Looks good.
>
> > 2. Fix repeated "to to" in several command reference files (toto.diff)
>
> - Specifies the name of the database to connect to to discover which
> + Specifies the name of the database to connect to discover which
>
> What's there is acceptable English, but it's maybe confusing to a
> non-native speaker and might be worth adjusting so it's easier to
> parse. "connect to to discover" is just short for "connect to in order
> to discover". If it's confusing, maybe we could rephrase the whole
> sentence. How about:
>
> "When the <option>-a</option>/<option>--all</option> is used, connect
> to this database to gather the list of databases to vacuum."
>
> > 3. Fix period instead of comma in enumeration (comma.diff)
>
> Looks good.
>
> > 4. Standardize inline tags in libpq documentation (tagmiss.diff)
>
> Looks good.
>
> > 5. Remove redundant "that that" constructions (thatthat.diff)
>
> I don't see anything wrong here. [1] does a better job of explaining
> #5 than I can.
>
> David
>
> [1] https://english.stackexchange.com/questions/492349/is-my-use-of-that-that-in-this-sentence-gramaticaly-correct
From | Date | Subject | |
---|---|---|---|
Next Message | Jacob Champion | 2025-04-21 23:19:06 | Re: [PoC] Federated Authn/z with OAUTHBEARER |
Previous Message | Jacob Champion | 2025-04-21 18:58:34 | Re: jsonapi: scary new warnings with LTO enabled |