| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | David Geier <geidav(dot)pg(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Hashed IN only applied to first encountered IN |
| Date: | 2025-04-01 23:00:01 |
| Message-ID: | CAApHDvqSFcGvyYVJZAk7BW544cd4KY3B9KofnjkCdpV49hwVGg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 2 Apr 2025 at 01:31, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Wed, 2 Apr 2025 at 00:51, David Geier <geidav(dot)pg(at)gmail(dot)com> wrote:
> > The hashed IN optimization is only applied to the first encountered
> > ScalarArrayOpExpr during the expression tree traversal in
> > convert_saop_to_hashed_saop_walker(). Reason being that the walker
> > returns true which aborts the traversal.
>
> > I've also attached a patch with a fix.
>
> Thanks for the report and fix. On first inspection your patch looks
> fine. I'll have a closer look tomorrow.
I've now pushed and backpatched the relevant portion of this back to v14.
Thanks again.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2025-04-01 23:02:54 | Re: Adding skip scan (including MDAM style range skip scan) to nbtree |
| Previous Message | Shayon Mukherjee | 2025-04-01 22:50:28 | Re: Proposal to Enable/Disable Index using ALTER INDEX (with patch) |