| From: | David Geier <geidav(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Hashed IN only applied to first encountered IN |
| Date: | 2025-04-02 09:44:28 |
| Message-ID: | 90f12d4a-e8b2-405a-9907-5bf205167961@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Great!
Thank you!
On 4/2/2025 1:00 AM, David Rowley wrote:
> On Wed, 2 Apr 2025 at 01:31, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>> On Wed, 2 Apr 2025 at 00:51, David Geier <geidav(dot)pg(at)gmail(dot)com> wrote:
>>> The hashed IN optimization is only applied to the first encountered
>>> ScalarArrayOpExpr during the expression tree traversal in
>>> convert_saop_to_hashed_saop_walker(). Reason being that the walker
>>> returns true which aborts the traversal.
>>> I've also attached a patch with a fix.
>> Thanks for the report and fix. On first inspection your patch looks
>> fine. I'll have a closer look tomorrow.
> I've now pushed and backpatched the relevant portion of this back to v14.
>
> Thanks again.
>
> David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2025-04-02 10:05:26 | Re: statistics import and export: another difference in dump/restore |
| Previous Message | Ilia Evdokimov | 2025-04-02 09:35:33 | Re: Add estimated hit ratio to Memoize in EXPLAIN to explain cost adjustment |