Re: PG15 beta1 sort performance regression due to Generation context change

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG15 beta1 sort performance regression due to Generation context change
Date: 2022-05-23 20:50:47
Message-ID: CAApHDvq0KwWdnqK0Ge5rv_2OQk8UAyyEMgDU1UiX5eka4NBDSQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 24 May 2022 at 08:32, Tomas Vondra
<tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
>
> On 5/20/22 12:01, Heikki Linnakangas wrote:
> > Could the 'context' field be moved from GenerationChunk to GenerationBlock?
> >
>
> Not easily, because GetMemoryChunkContext() expects the context to be
> stored right before the chunk. In principle we could add "get context"
> callback to MemoryContextMethods, so that different implementations can
> override that.

hmm, but we need to know the context first before we can know which
callback to call.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2022-05-23 20:52:10 Re: PG15 beta1 sort performance regression due to Generation context change
Previous Message Tom Lane 2022-05-23 20:47:51 Re: PG15 beta1 sort performance regression due to Generation context change