| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PG15 beta1 sort performance regression due to Generation context change |
| Date: | 2022-05-23 20:52:10 |
| Message-ID: | 007af81a-08a8-42ba-c81f-739dfe98deeb@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5/23/22 22:47, Tom Lane wrote:
> Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> writes:
>> On 5/20/22 12:01, Heikki Linnakangas wrote:
>>> Could the 'context' field be moved from GenerationChunk to GenerationBlock?
>
>> Not easily, because GetMemoryChunkContext() expects the context to be
>> stored right before the chunk. In principle we could add "get context"
>> callback to MemoryContextMethods, so that different implementations can
>> override that.
>
> How would you know which context type to consult for that?
>
D'oh! I knew there has to be some flaw in that idea, but I forgot about
this chicken-or-egg issue.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2022-05-23 21:01:15 | Re: PG15 beta1 sort performance regression due to Generation context change |
| Previous Message | David Rowley | 2022-05-23 20:50:47 | Re: PG15 beta1 sort performance regression due to Generation context change |