Re: Speeding Up Bitmapset

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Speeding Up Bitmapset
Date: 2023-06-26 04:20:42
Message-ID: CAApHDvpaWoT+Nx0iMaJ2rbD1eYx2J66Urs4=jQQg=CX32pFfHQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 26 Jun 2023 at 12:55, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
>
> Em dom., 25 de jun. de 2023 às 17:49, David Rowley <dgrowleyml(at)gmail(dot)com> escreveu:
>>
>> There's no reason in the world
>> that those will speed up Bitmapsets, so why include them?
>
> Of course optimization is the most important thing,
> but since you're going to touch the source, why not make it more readable.

Have a look at [1]. In particular "Reasons your patch might be
returned" and precisely "Reformatting lines that haven't changed"

That entire page is quite valuable and I'd recommend having a read of all of it.

David

[1] https://wiki.postgresql.org/wiki/Submitting_a_Patch

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2023-06-26 05:45:28 Re: Synchronizing slots from primary to standby
Previous Message Amit Kapila 2023-06-26 04:18:24 Re: Assert while autovacuum was executing