Re: Assert while autovacuum was executing

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Assert while autovacuum was executing
Date: 2023-06-26 04:18:24
Message-ID: CAA4eK1LuRM5ayyhjDW-c7OwCajhNiWQdofv3U01ai0=E+-Vr1A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 23, 2023 at 10:07 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> On 2023-06-23 14:04:15 +0530, Amit Kapila wrote:
> > OTOH, if the above theory is wrong or people are not convinced, I am
> > okay with removing all the changes in commits 72e78d831a and
> > 3ba59ccc89.
>
> I am not convinced. And even if I were, coming up with new justifications in a
> released version, when the existing testing clearly wasn't enough to find the
> current bug, doesn't strike me as wise.
>

Fair enough. If we could have been convinced of this then we can keep
the required change only for HEAD. But anyway let's remove the work
related to both commits (72e78d831a and 3ba59ccc89) for now and then
we can come back to it when we parallelize writes. The attached patch
removes the changes added by both commits with slight tweaking in
comments/readme based on the recent state.

--
With Regards,
Amit Kapila.

Attachment Content-Type Size
v1-0001-Revert-the-commits-related-to-allowing-page-lock-.patch application/octet-stream 10.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2023-06-26 04:20:42 Re: Speeding Up Bitmapset
Previous Message Kirk Wolak 2023-06-26 03:26:38 Re: RFC: Adding \history [options] [filename] to psql (Snippets and Shared Queries)