| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Making aggregate deserialization (and WAL receive) functions slightly faster |
| Date: | 2023-10-30 20:55:21 |
| Message-ID: | CAApHDvpUGzJSPkWTJfOn_5bwbzA=yHjMmSLHfbYoBjrB4eji4g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 30 Oct 2023 at 23:48, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Oct 27, 2023 at 3:23 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > * parallel.c in HandleParallelMessages():
> > * applyparallelworker.c in HandleParallelApplyMessages():
>
> Both the above calls are used to handle ERROR/NOTICE messages from
> parallel workers as you have also noticed. The comment atop
> initReadOnlyStringInfo() clearly states that it is used in the
> performance-critical path. So, is it worth changing these places? In
> the future, this may pose the risk of this API being used
> inconsistently.
I'm ok to leave those ones out. But just a note on the performance
side, if we go around needlessly doing palloc/memcpy then we'll be
flushing possibly useful cachelines out and cause slowdowns elsewhere.
That's a pretty hard thing to quantify, but something to keep in mind.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2023-10-30 21:01:28 | Re: always use runtime checks for CRC-32C instructions |
| Previous Message | Jeff Davis | 2023-10-30 20:48:29 | Re: always use runtime checks for CRC-32C instructions |