| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Making aggregate deserialization (and WAL receive) functions slightly faster |
| Date: | 2023-11-02 09:41:59 |
| Message-ID: | CAA4eK1KDA=avN-4Dq6KJph+a=GVi6US_BCCZ6Wf1JW9eeZ2hAQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 31, 2023 at 2:25 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Mon, 30 Oct 2023 at 23:48, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Fri, Oct 27, 2023 at 3:23 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > > * parallel.c in HandleParallelMessages():
> > > * applyparallelworker.c in HandleParallelApplyMessages():
> >
> > Both the above calls are used to handle ERROR/NOTICE messages from
> > parallel workers as you have also noticed. The comment atop
> > initReadOnlyStringInfo() clearly states that it is used in the
> > performance-critical path. So, is it worth changing these places? In
> > the future, this may pose the risk of this API being used
> > inconsistently.
>
> I'm ok to leave those ones out.
>
The other two look good to me.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stefan Kaltenbrunner | 2023-11-02 09:51:03 | Re: Including Doxyfile and Meson script for docs into main source tree |
| Previous Message | John Naylor | 2023-11-02 09:41:04 | Re: Commitfest manager November 2023 |