Re: minor comments issue in ResultRelInfo src/include/nodes/execnodes.h

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: minor comments issue in ResultRelInfo src/include/nodes/execnodes.h
Date: 2024-08-12 11:42:18
Message-ID: CAApHDvp0fSDD8nswhmZZPJ=J5haNaAN=UuymYst+jmF-2wvc+g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 12 Aug 2024 at 22:32, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Mon, 12 Aug 2024 at 22:03, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> > I think first ri_RowIdAttNo applies to MERGE also. so the comments may
> > not be correct?
>
> Yeah, ri_RowIdAttNo is used for MERGE. We should fix that comment.
>
> > Other files comments are fine.
>
> I'd say ri_GeneratedExprsI and ri_GeneratedExprsU are also used for
> MERGE and the comment for those is also outdated. See:

I've pushed a patch to fix these. Thanks for the report.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alena Rybakina 2024-08-12 11:44:05 Re: Add support for (Var op Var) clause in extended MCV statistics
Previous Message Amit Kapila 2024-08-12 11:40:47 Re: Conflict detection and logging in logical replication