Re: Incorrect CHUNKHDRSZ in nodeAgg.c

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Incorrect CHUNKHDRSZ in nodeAgg.c
Date: 2025-01-15 08:01:09
Message-ID: CAApHDvor5NL7sKwf4-yw_qK_T9n2Sh=gfVaoojOFBbfA487njw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 14 Jan 2025 at 09:09, Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
> Attached v2.

This needs to be rebased due to b4a07f532.

The following repalloc was removed by that commit.

- totalsize = MAXALIGN(firstTuple->t_len) + hashtable->additionalsize;
- firstTuple = repalloc(firstTuple, totalsize);
+ totalsize = MAXALIGN(mtup->t_len) + hashtable->additionalsize;
+ firstTuple = MemoryContextAlloc(hashtable->tablecxt, totalsize);
+ memcpy(firstTuple, mtup, mtup->t_len);

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nazir Bilal Yavuz 2025-01-15 08:03:54 Re: per backend I/O statistics
Previous Message jian he 2025-01-15 07:51:04 Re: pg_dump, pg_dumpall, pg_restore: Add --no-policies option