| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Incorrect Assert in BufFileSize()? |
| Date: | 2024-07-03 21:46:24 |
| Message-ID: | CAApHDvod-92Y2Yb+ktz3fx=zH1B2fTO7zy-ic60dMDbUQoDxnw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 4 Jul 2024 at 04:19, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> - * Return the current fileset based BufFile size.
> + * Returns the size if the given BufFile in bytes.
>
> "Returns the size of", no doubt?
Yes, thanks.
> A shade less nit-pickily, I wonder if "size" is sufficient.
> It's not really obvious that this means the amount of data
> in the file, rather than say sizeof(BufFile). How about
>
> + * Returns the amount of data in the given BufFile, in bytes.
I've used that. Thank you.
> LGTM other than that point.
Pushed.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2024-07-03 22:54:18 | Cleanup: PGProc->links doesn't need to be the first field anymore |
| Previous Message | Jeff Davis | 2024-07-03 21:19:07 | Re: Built-in CTYPE provider |