| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Incorrect Assert in BufFileSize()? |
| Date: | 2024-07-03 16:19:18 |
| Message-ID: | 3260453.1720023558@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> I've attached an updated patch which updates the comments and also
> removes the misplaced Asserts from BufFileAppend.
> If there are no objections or additional feedback, I'll push this patch soon.
- * Return the current fileset based BufFile size.
+ * Returns the size if the given BufFile in bytes.
"Returns the size of", no doubt?
A shade less nit-pickily, I wonder if "size" is sufficient.
It's not really obvious that this means the amount of data
in the file, rather than say sizeof(BufFile). How about
+ * Returns the amount of data in the given BufFile, in bytes.
LGTM other than that point.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2024-07-03 16:20:21 | Re: Add support to TLS 1.3 cipher suites and curves lists |
| Previous Message | Marat Bukharov | 2024-07-03 16:04:40 | Re: [PATCH] Add min/max aggregate functions to BYTEA |