Re: PATCH: pgAdmin4 windows installer

From: Paresh More <paresh(dot)more(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com>, Hamid Quddus <hamid(dot)quddus(at)enterprisedb(dot)com>
Subject: Re: PATCH: pgAdmin4 windows installer
Date: 2016-06-08 06:23:29
Message-ID: CAAgiCNF+PSOA9dsUf90dCDLTqj9GEzA-qT7gNk5q9RqFj+0Aqg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hello Dave,

As discuss added vcdist runtime, remove splash screen and added start menu
icon.

Now also inno setup standard and Unicode both version are working fine.

Attached is the updated patch.

On Mon, Jun 6, 2016 at 2:51 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi,
>
> On Fri, Jun 3, 2016 at 9:30 PM, Paresh More <paresh(dot)more(at)enterprisedb(dot)com>
> wrote:
>
>> Hello Dave.
>>
>> There was problem with the Make.bat file ^M characters which is been
>> removed.
>>
>> Issues are fixed along with some code and README tidied
>>
>
> I'm still seeing the same error:
>
> copy "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss.in"
> "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss"
> 1 file(s) copied.
> Error on line 113 in
> C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 3:
> Semicolon (';') expected.
> Compile aborted.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--

Thanks & Regards

*Paresh More*

[image: NEW-EDB-logo-4c]

Pune, India.
Cell : +919922000564 | www.enterprisedb.com

Attachment Content-Type Size
pgadmin4_window_8_June_2016.patch application/octet-stream 59.8 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-06-08 08:30:56 pgAdmin 4 commit: Fix styling of statistics table. Fixes #1315
Previous Message Ashesh Vashi 2016-06-08 06:16:53 Re: PATCH: Added Statistics functionality for many nodes (pgAdmin4)