Re: PATCH: pgAdmin4 windows installer

Thanks! That's now committed, with a few modifications:

- Install/uninstall Sphinx as it's not actually in the requirements.txt
file and is only needed for building.
- Detect errors in the doc build.
- Rename ve_python to venv for consistency with Mac.
- Comment/progress info improvements

On Wed, Jun 8, 2016 at 7:23 AM, Paresh More <paresh(dot)more(at)enterprisedb(dot)com>
wrote:

> Hello Dave,
>
> As discuss added vcdist runtime, remove splash screen and added start menu
> icon.
>
> Now also inno setup standard and Unicode both version are working fine.
>
>
>
> Attached is the updated patch.
>
>
> On Mon, Jun 6, 2016 at 2:51 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi,
>>
>> On Fri, Jun 3, 2016 at 9:30 PM, Paresh More <paresh(dot)more(at)enterprisedb(dot)com
>> > wrote:
>>
>>> Hello Dave.
>>>
>>> There was problem with the Make.bat file ^M characters which is been
>>> removed.
>>>
>>> Issues are fixed along with some code and README tidied
>>>
>>
>> I'm still seeing the same error:
>>
>> copy "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss.in"
>> "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss"
>> 1 file(s) copied.
>> Error on line 113 in
>> C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 3:
>> Semicolon (';') expected.
>> Compile aborted.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
>
> Thanks & Regards
>
> *Paresh More*
>
> [image: NEW-EDB-logo-4c]
>
> Pune, India.
> Cell : +919922000564 | www.enterprisedb.com
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company