Re: PL/Java new build plugin

From: Kartik Ohri <kartikohri13(at)gmail(dot)com>
To: Chapman Flack <chap(at)anastigmatix(dot)net>
Cc: pljava-dev(at)lists(dot)postgresql(dot)org
Subject: Re: PL/Java new build plugin
Date: 2020-08-08 14:00:31
Message-ID: CAASLQ4O5Wfk1hH6nO_1PDUbRcpUywvTxq7e99aCJ4RPeMmssAw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pljava-dev

On Wed, Aug 5, 2020 at 9:09 AM Chapman Flack <chap(at)anastigmatix(dot)net> wrote:

> On 08/04/20 08:07, Kartik Ohri wrote:
>
> > how it would work. I did try to go this route but I felt that it was
> > getting a bit difficult. So, after some thinking I moved the hard coded
> > values to the default values of the interface and utilised it in the
> mojo.
> > This approach worked well and I have pushed the changes. I have also
> pushed
> > a working example to test it. Please review it and let me know if changes
> > are required.
>
> I've created a branch
> https://github.com/jcflack/pljava/commits/invocable
> where you can see the way I had in mind for it to work.
>
> I took a look and this way seems to be really better than how I had done
it. Now that I look at it I feel if I had tried harder, I could have made
it work myself. I'll try harder next time. Thanks for helping with this.
I'll merge this into my branch and begin work on the nar maven part.

> It seems to, although javadoc still seems to be ignoring my
> --show-packages all, as I had noticed before; I still don't know why,
> but I don't think it's the mojo's fault.
>
> Regards,
> -Chap
>
Regards,
Kartik

In response to

Responses

Browse pljava-dev by date

  From Date Subject
Next Message Chapman Flack 2020-08-08 14:13:39 Re: PL/Java new build plugin
Previous Message Chapman Flack 2020-08-05 03:39:16 Re: PL/Java new build plugin