Re: pgsql: Consolidate docs for vacuum-related GUCs in new subsection

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Consolidate docs for vacuum-related GUCs in new subsection
Date: 2025-01-13 15:22:15
Message-ID: CAAKRu_bWLXoJv0cgW=mrt3aPqy9muxz+3SVy8+LoWyZkfL1smQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Thanks to Álvaro for pointing this out. I didn't think of it.

On Sun, Jan 12, 2025 at 2:21 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> > On 11 Jan 2025, at 10:02, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> >> and the GUC grouping in guc_tables.c/h?
>
> > I don't know what our policy around this is, and maybe the backpatching hazard
> > isn't too bad here, but it doesn't entirely seem worth the churn.
>
> I think the entire point of that categorization is to line up with the
> docs, so our policy should be to fix this.

I wrote a patch to reorder postgresql.conf.sample. But when I started
looking at guc_tables.c, it doesn't seem like those are grouped
according to the current docs order. Part of this is because some of
the GUCs have different data types. But this appears to be more than
that. For example, in master guc_tables.c,
autovacuum_vacuum_cost_limit and vacuum_cost_limit are together (in
docs in master they were in different sub-sections). Is guc_tables.c
meant to be consistent with the ordering in the docs?

- Melanie

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2025-01-13 15:37:49 pgsql: Add commit 6e826278f1 to .git-blame-ignore-revs.
Previous Message Richard Guo 2025-01-13 02:27:56 pgsql: Fix pgindent damage

Browse pgsql-hackers by date

  From Date Subject
Next Message Malladi, Rama 2025-01-13 15:28:30 Re: [PATCH] SVE popcount support
Previous Message Daniel Gustafsson 2025-01-13 14:18:37 Re: Replace current implementations in crypt() and gen_salt() to OpenSSL