Re: Eagerly scan all-visible pages to amortize aggressive vacuum

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>
Cc: Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>, Robert Treat <rob(at)xzilla(dot)net>
Subject: Re: Eagerly scan all-visible pages to amortize aggressive vacuum
Date: 2025-01-15 20:55:52
Message-ID: CAAKRu_bV3kyojYukHCEOJsLdSLgybSuCKXhQRBMKd6pUG52EUQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 15, 2025 at 3:03 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> On Wed, Jan 15, 2025 at 2:36 PM Marcos Pegoraro <marcos(at)f10(dot)com(dot)br> wrote:
> >>
> > There is a typo on committed vacuumlazy.c file
> > * If the TID store fills up in phase I, vacuum suspends phase I, proceeds to
> > * phases II and II, cleaning up the dead tuples referenced in the current TID
> > * store. This empties the TID store resumes phase I.
> >
> > Probably you meant phases II and III
>
> Oops. Thanks for catching this. I'll fix that and the following
> sentence in the main patch proposed in this thread to avoid extra
> noise.

Attached v8 is rebased and has various comment cleanups.

- Melanie

Attachment Content-Type Size
v8-0001-Eagerly-scan-all-visible-pages-to-amortize-aggres.patch application/octet-stream 40.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Corey Huinker 2025-01-15 20:56:04 Re: Statistics Import and Export
Previous Message Jeff Davis 2025-01-15 20:42:46 Re: Collation & ctype method table, and extension hooks