| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tv(at)fuzzy(dot)cz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Can rs_cindex be < 0 for bitmap heap scans? |
| Date: | 2024-10-25 16:37:09 |
| Message-ID: | CAAKRu_bQFd=cgNMHED0VUPfV-fUcdsj2SBxRYD5DZmmJLg387A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 25, 2024 at 10:29 AM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> Tom suggested off-list that if rs_cindex can't be zero, then it should
> be unsigned. I checked the other scan types using the
> HeapScanDescData, and it seems none of them use values of rs_cindex or
> rs_ntuples < 0. As such, here is a patch making both rs_ntuples and
> rs_cindex unsigned.
I realized one of the asserts was superfluous. Please find v3 attached.
- Melanie
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Make-rs_cindex-and-rs_ntuples-unsigned.patch | text/x-patch | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bernd Helmle | 2024-10-25 16:41:39 | Re: [PATCH] Add sortsupport for range types and btree_gist |
| Previous Message | Tom Lane | 2024-10-25 15:48:29 | Re: Fix C23 compiler warning |