Re: Moving the vacuum GUCs' docs out of the Client Connection Defaults section

On Wed, Jan 8, 2025 at 8:39 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 07.01.25 18:31, Melanie Plageman wrote:
> >
> > Oh, one thing I forgot to say. Though I increased the indentation of
> > some of the subsections that I moved, I didn't rewrap the lines
> > because they were already not wrapped to 78. I can do this, but I
> > can't tell from the existing docs what text width the paragraphs of
> > text are supposed to be wrapped to.
>
> For a patch that moves things around like this, I would leave everything
> as is and not rewrap. That makes it easier to follow what's going on
> with "git diff -w", "git show -w" etc.
>
> In .dir-locals.el, there is this configuration for Emacs:
>
> (nxml-mode . ((fill-column . 78)
> (indent-tabs-mode . nil)))
>
> So that's one data point about what the line length should be.

Well, in this case, the diff won't look different with git show/diff
-w because moving them to another part of the file is more than a
whitespace change. For clarity, I added a note to the commit message
that the actual GUCs' docs are just lifted and shifted.

I decided in the end not to wrap it anyway, though. I tried it and
didn't like the result. If I wrap it to 78, that actually makes a good
number of the GUCs' docs wider (i.e. they were wrapped to less than
78). Which means future additions are more likely to need to wrap (as
Tom mentioned upthread).

Attached is v2 (required a rebase).

- Melanie