Re: Moving the vacuum GUCs' docs out of the Client Connection Defaults section

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Melanie Plageman <melanieplageman(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Moving the vacuum GUCs' docs out of the Client Connection Defaults section
Date: 2025-01-08 13:39:26
Message-ID: 68a4435c-3990-419d-a68a-b33a7f9185ab@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 07.01.25 18:31, Melanie Plageman wrote:
> On Tue, Jan 7, 2025 at 12:15 PM Melanie Plageman
> <melanieplageman(at)gmail(dot)com> wrote:
>>
>> Cool, I've attached a patch to do this. I left a few of the GUCs under
>> Resource Consumption (like autovacuum_work_mem and
>> vacuum_buffer_usage_limit) where they are because it seemed
>> appropriate.
>>
>> This is my first docs patch that introduces new sections and such, so
>> I'm not sure I got the indentation 100% correct (I, of course, tried
>> to follow conventions).
>
> Oh, one thing I forgot to say. Though I increased the indentation of
> some of the subsections that I moved, I didn't rewrap the lines
> because they were already not wrapped to 78. I can do this, but I
> can't tell from the existing docs what text width the paragraphs of
> text are supposed to be wrapped to.

For a patch that moves things around like this, I would leave everything
as is and not rewrap. That makes it easier to follow what's going on
with "git diff -w", "git show -w" etc.

In .dir-locals.el, there is this configuration for Emacs:

(nxml-mode . ((fill-column . 78)
(indent-tabs-mode . nil)))

So that's one data point about what the line length should be.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2025-01-08 13:41:50 Re: Virtual generated columns
Previous Message Alvaro Herrera 2025-01-08 13:36:08 Re: CREATE TABLE NOT VALID for check and foreign key