Re: Introduce "log_connection_stages" setting.

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Sergey Dudoladov <sergey(dot)dudoladov(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Subject: Re: Introduce "log_connection_stages" setting.
Date: 2025-03-03 14:40:00
Message-ID: CAAKRu_Z5X1NsCzx6SXZQAt=XX9Vu8bmDy_gY01Zu-iiTH+ychQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 3, 2025 at 5:43 AM Sergey Dudoladov
<sergey(dot)dudoladov(at)gmail(dot)com> wrote:
>
> I must admit I haven't seen the [1] either. Thank you for pointing that out, Bertrand.
> I agree the patch from Melanie is very close to this patch.
>
> Melanie, do you think it is realistic to merge the v8-0001-Modularize-log_connections-output.patch from [1] during the current commitfest ?

I'd certainly like to merge it in 18. The patch itself needs more
work, which I'm planning on doing this week. I think we have a
reasonable amount of consensus on using GUC_LIST_INPUT.

I am less sure about merging log_disconnections into log_connections.
I think it makes sense in principle. But, in 18, when people satisfied
with existing behavior change log_connections from 'on' to 'all' to
comply with the new format, they will get the disconnections messages.

I am still somewhat nervous about merging the patch in general and
people being surprised because they didn't pay attention to the
discussion and now log_connections is different and they would have
-1'd if they'd been paying attention.

- Melanie

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2025-03-03 15:05:18 Re: RFC: Additional Directory for Extensions
Previous Message jian he 2025-03-03 14:20:21 Re: bug when apply fast default mechanism for adding new column over domain with default value