Re: Using read_stream in index vacuum

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Kirill Reshke <reshkekirill(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: Using read_stream in index vacuum
Date: 2025-03-21 19:23:50
Message-ID: CAAKRu_YrUGuvUyAw_a+0fQ1A6n4MsKu38L34xDb+AVjnGSJMXA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 21, 2025 at 8:19 AM Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>
> > On 21 Mar 2025, at 05:54, Melanie Plageman <melanieplageman(at)gmail(dot)com> wrote:
> >
> > I also think it is worth making a btree directory in src/test instead
> > of adding this to src/test/modules/test_misc. In fact it might be
> > worth moving the gin and brin tests out of src/test/modules and making
> > a new "indexes" directory in src/test with gin, brin, and btree (also
> > some spgist tests are in there somewhere) subdirectories.
>
> Previously we groupped injection point tests in small number of modules, because it required additional changes to build files. And we only had like 3 or 5 tests.
> I think if we have a handful of tests - it’s time to start organizing them in a structured way.

There are tests with injection points in all different test
directories now. I think regress is the only one where it would be too
much of a pain.

I've committed the btree and gist read stream users. I think we can
come back to the test after feature freeze and make sure it is super
solid.

Looking at the spgist read stream user, I see you didn't convert
spgprocesspending(). It seems like you could write a callback that
uses the posting list and streamify this as well.

- Melanie

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alena Rybakina 2025-03-21 19:42:17 Re: Vacuum statistics
Previous Message Robert Haas 2025-03-21 19:23:38 Re: Parallel safety for extern params